This revision was automatically updated to reflect the committed changes.
Closed by commit rL317677: Avoid printing some redundant name qualifiers in
completion (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D38538
Files:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
cfe/
ilya-biryukov updated this revision to Diff 120016.
ilya-biryukov added a comment.
- Extracted the move of QualTypeNames to AST into a separate revision.
https://reviews.llvm.org/D38538
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/call.cpp
test/CodeCompletion/qualifiers-as-wri
arphaman accepted this revision.
arphaman added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29
+ // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar
c#>, <#ns::baz d#>
+ // C
ilya-biryukov added a comment.
Friendly ping.
Would it be okay to make the new behaviour optional? (Leaving old behaviour to
be the default).
https://reviews.llvm.org/D38538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
ilya-biryukov added inline comments.
Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29
+ // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar
c#>, <#ns::baz d#>
+ // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz
c#>
arphaman added inline comments.
Comment at: test/CodeCompletion/qualifiers-as-written.cpp:29
+ // CHECK-2: COMPLETION: func : [#int#]func(<#foo a#>, <#bar b#>, <#ns::bar
c#>, <#ns::baz d#>
+ // CHECK-2: COMPLETION: func : [#int#]func(<#foo::type a#>, <#bar b#>, <#baz
c#>
+}
-
ilya-biryukov added inline comments.
Comment at: test/CodeCompletion/enum-switch-case-qualified.cpp:25
// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:23:8 %s -o - |
FileCheck -check-prefix=CHECK-CC1 %s
-// CHECK-CC1: Blue : [#M::N::C::Color#]N::C::Blue
-//
ilya-biryukov updated this revision to Diff 118185.
ilya-biryukov added a comment.
Herald added a subscriber: mgorny.
- Restore qualifiers for types of EnumConstantDecl.
https://reviews.llvm.org/D38538
Files:
include/clang/AST/QualTypeNames.h
include/clang/Tooling/Core/QualTypeNames.h
lib
ilya-biryukov added inline comments.
Comment at: test/CodeCompletion/call.cpp:22
// CHECK-CC1: COMPLETION: Pattern : dynamic_cast<<#type#>>(<#expression#>)
- // CHECK-CC1: f(N::Y y, <#int ZZ#>)
+ // CHECK-CC1: f(Y y, <#int ZZ#>)
// CHECK-CC1-NEXT: f(int i, <#int j#>, int
ilya-biryukov updated this revision to Diff 118205.
ilya-biryukov added a comment.
- Included more cases into a qualifiers-as-written.cpp test.
https://reviews.llvm.org/D38538
Files:
include/clang/AST/QualTypeNames.h
include/clang/Tooling/Core/QualTypeNames.h
lib/AST/CMakeLists.txt
lib/
arphaman added inline comments.
Comment at: test/CodeCompletion/call.cpp:22
// CHECK-CC1: COMPLETION: Pattern : dynamic_cast<<#type#>>(<#expression#>)
- // CHECK-CC1: f(N::Y y, <#int ZZ#>)
+ // CHECK-CC1: f(Y y, <#int ZZ#>)
// CHECK-CC1-NEXT: f(int i, <#int j#>, int k)
--
ilya-biryukov added inline comments.
Comment at: test/CodeCompletion/enum-switch-case-qualified.cpp:25
// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:23:8 %s -o - |
FileCheck -check-prefix=CHECK-CC1 %s
-// CHECK-CC1: Blue : [#M::N::C::Color#]N::C::Blue
-//
ilya-biryukov created this revision.
Herald added a subscriber: eraman.
Adjusted PrintingPolicy inside code completion to avoid printing some
redundant name qualifiers.
Before this change, typedefs that were written unqualified in source
code were printed with qualifiers in completion. For exampl
13 matches
Mail list logo
