[PATCH] D37134: [libc++] Use CMAKE_AR for merging static libraries

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL313122: Use CMAKE_AR instead of the system default 'ar' for merging static libraries (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D37134?vs=114908&id=114981#toc Repository:

[PATCH] D37134: [libc++] Use CMAKE_AR for merging static libraries

2017-09-12 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. LGTM, minus inline comments. Comment at: utils/merge_archives.py:97 parser.add_argument( +'-a', '--ar', dest='ar_exe', required=False, +help='The ar executable to use, finds \'ar\' in the path if not gi

[PATCH] D37134: [libc++] Use CMAKE_AR for merging static libraries

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo updated this revision to Diff 114908. mstorsjo added a comment. The previous patch actually lacked the 's' option that the summary talked about https://reviews.llvm.org/D37134 Files: lib/CMakeLists.txt utils/merge_archives.py Index: utils/merge_archives.py ===

[PATCH] D37134: [libc++] Use CMAKE_AR for merging static libraries

2017-09-12 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo updated this revision to Diff 114907. mstorsjo retitled this revision from "[libc++] Rerun ranlib manually after merging the static libraries" to "[libc++] Use CMAKE_AR for merging static libraries". mstorsjo edited the summary of this revision. https://reviews.llvm.org/D37134 Files: