EricWF accepted this revision.
EricWF added a comment.

LGTM, minus inline comments.



================
Comment at: utils/merge_archives.py:97
     parser.add_argument(
+        '-a', '--ar', dest='ar_exe', required=False,
+        help='The ar executable to use, finds \'ar\' in the path if not given',
----------------
`-a` doesn't feel very descriptive, and unlike `-o` and `-L` it isn't used 
commonly elsewhere. Maybe just the long option on this one?


https://reviews.llvm.org/D37134



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to