[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-03 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL30: Enable AddressSanitizer for Fuchsia targets (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35922?vs=109605&id=109645#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-03 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr updated this revision to Diff 109605. mcgrathr added a comment. Check -dynamic-linker in test. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchs

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. LGTM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-02 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr updated this revision to Diff 109428. mcgrathr added a comment. Added tests. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c =

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-02 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. One more thing, would it be possible add a test case to `test/Driver/fuchsia.c` covering this? Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-01 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() mcgrathr wrote: > ph

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-01 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-08-01 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() phosek wrote: > I

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-07-26 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() I think we also need

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

2017-07-26 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr created this revision. mcgrathr added a project: Sanitizers. Herald added subscribers: mgorny, srhines. Repository: rL LLVM https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp Index: lib/Driver