[PATCH] D35894: Code hover for Clangd

2017-07-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. arphaman added inline comments. Comment at: clangd/Protocol.h:106 Range range; + FileID unitFileID; It doesn't look like it's appropriate to store a translation unit specific value in the `Location` which, if I'm not mistaken, is

[PATCH] D35894: Code hover for Clangd

2017-07-26 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle requested changes to this revision. malaperle added a comment. This revision now requires changes to proceed. Normally we put [clangd] in the title. Comment at: clangd/ClangdLSPServer.cpp:11 #include "ClangdLSPServer.h" +#include "clang/Basic/SourceManager.h" #inclu