arphaman added a comment. arphaman added inline comments.
================ Comment at: clangd/Protocol.h:106 Range range; + FileID unitFileID; ---------------- It doesn't look like it's appropriate to store a translation unit specific value in the `Location` which, if I'm not mistaken, is supposed to be composed of values that are directly present in the protocol. I think it would be more appropriate to teach `ClangdUnit` how to convert a URI to a `FileID`. Then you won't have a need for this field. Repository: rL LLVM https://reviews.llvm.org/D35894 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
