[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

2017-07-18 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL308390: [Driver] Always use -z rodynamic for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35582?vs=107185&id=107200#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

2017-07-18 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

2017-07-18 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 107185. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D35582 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ==

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

2017-07-18 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr requested changes to this revision. mcgrathr added a comment. This revision now requires changes to proceed. Looks almost right. Might be overkill to add a test case that -z rodynamic is omitted with -fuse-ld=gold or something. Comment at: lib/Driver/ToolChains/Fuchs

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

2017-07-18 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. Fuchsia uses read-only .dynamic section. Repository: rL LLVM https://reviews.llvm.org/D35582 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp ===