mcgrathr requested changes to this revision.
mcgrathr added a comment.
This revision now requires changes to proceed.
Looks almost right. Might be overkill to add a test case that -z rodynamic is
omitted with -fuse-ld=gold or something.
================
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:51
+ CmdArgs.push_back("-z");
+ CmdArgs.push_back("rodynamic");
----------------
Should be inside the lld conditional, since only lld groks -z rodynamic.
Repository:
rL LLVM
https://reviews.llvm.org/D35582
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
