rnkovacs added a comment.
Dependent types seem to work, but we did manage to produce a crash on
incomplete types. I created https://reviews.llvm.org/D35790 for that. I hope
it's the same problem you encountered.
Repository:
rL LLVM
https://reviews.llvm.org/D35051
alexfh added a comment.
The top of stack trace is:
clang::CXXRecordDecl::isTriviallyCopyable()
(unknown)
clang::tidy::bugprone::(anonymous
namespace)::internal::matcher_isNotTriviallyCopyableMatcher::matches()
Repository:
rL LLVM
https://reviews.llvm.org/D35051
alexfh added a comment.
FYI, bugprone-undefined-memory-manipulation crashes on some of our code. I
guess, this happens with dependent types, but I don't have an isolated repro
yet.
Repository:
rL LLVM
https://reviews.llvm.org/D35051
___
cfe-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308021: [clang-tidy] Add
bugprone-undefined-memory-manipulation check (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D35051?vs=106234&id=106625#toc
Repository:
rL LLVM
https:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp:39
+ // Check whether source object is not TriviallyCopyable.
+ // Only applicable to memcpy() and m
rnkovacs marked 2 inline comments as done.
rnkovacs added inline comments.
Comment at: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp:39
+ // Check whether source object is not TriviallyCopyable.
+ // Only applicable to memcpy() and memmove().
+ Finder->addMatcher(
-
rnkovacs updated this revision to Diff 106234.
rnkovacs added a comment.
Herald added a subscriber: baloghadamsoftware.
Removed redundant parens and stray semicolons.
https://reviews.llvm.org/D35051
Files:
clang-tidy/bugprone/BugproneTidyModule.cpp
clang-tidy/bugprone/CMakeLists.txt
clang
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp:22
+AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
+ return !(Node.isTriviallyCopyab
rnkovacs updated this revision to Diff 106185.
rnkovacs retitled this revision from "[clang-tidy] Add
misc-undefined-memory-manipulation check." to "[clang-tidy] Add
bugprone-undefined-memory-manipulation check.".
rnkovacs edited the summary of this revision.
rnkovacs added a comment.
- Moved to
