alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
================
Comment at: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp:22
+AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
+ return !(Node.isTriviallyCopyable());
+}
----------------
nit: No need for the parentheses.
================
Comment at: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp:39
+ // Check whether source object is not TriviallyCopyable.
+ // Only applicable to memcpy() and memmove().
+ Finder->addMatcher(
----------------
What about `memset`?
================
Comment at: test/clang-tidy/bugprone-undefined-memory-manipulation.cpp:34
+struct Destruct {
+ ~Destruct() {};
+};
----------------
Remove stray semicolons after closing braces of function bodies.
https://reviews.llvm.org/D35051
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
