[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

justincady added subscribers: njames93, LegalizeAdulthood, justincady. justincady added a comment. This feature appears to have strong user support throughout this review, and a lot of people (including myself) seem interested in having it landed. cc'ing some clang-tidy owners

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

aminya added a comment. Clang-tidy is very slow if you use it on a medium or large project. Something like this feature, even if it is not perfect, will definitely improve the experience with clang-tidy. The low performance of clang-tidy is one of the biggest frictions for using it. Repositor

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. Here's a patch that uses Globs, let me know how you like it! https://reviews.llvm.org/D112720 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654 ___ c

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. > everyone has .* in their config file, which will silently stop to work Nevermind this. `.*` treated as a glob will turn into the regex `..*` which is equivalent. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://re

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. Also, the new header filter expresion would need to be: `HeaderFilter: '*/mydir/*' instead of `HeaderFilter: 'mydir'` Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. On the other hand, switching from Regex to Glob will be quite a breaking change - everyone has `.*` in their config file, which will silently stop to work when switching to Glob and suddenly people won't get their headers linted. What do you think? Repository:

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

carlosgalvezp added a comment. I've recently fiddled with the `GlobList` to enable globbing in `NOLINT` expressions, so I have it quite fresh and I think it could easily be re-used here. I'd be happy to implement this feature, should I (can I?) continue on this patch or create a brand new one?

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Ashimaru added a comment. In D34654#3022728 , @alexfh wrote: > Repeating my question from an earlier comment: would a header glob list > (similar to how the format of the `-checks=` flag) be enough for the use > cases folks have? On the one hand glob lis

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

aco added a comment. Hi, first of all I want to say that the name "HeaderFilterRegex" is a bit ambiguous, we don't know intuitively if we define what is filtered or what passes. in my humble opinion alexfh's proposal would be much easier to use than 2 regex. In D34654#3022728

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

alexfh added a comment. Repeating my question from an earlier comment: would a header glob list (similar to how the format of the `-checks=` flag) be enough for the use cases folks have? On the one hand glob list doesn't support all the features of regular expressions, but are they all useful f

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Ashimaru added a comment. In my company we are using a lot of standard checks and it becomes time consuming - this patch would be extremely useful to us and non of proposals montioned @alexfh seem to solve the issue. We would like to select which directories containing headers would be checked

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

MartinG added a comment. More than 3.5 years later and this extremely basic feature hasn't been merged yet? Clang-tidy's interface is completely broken. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Hiralo added a comment. We are dependent on this patch to exclude headers in regex while running clang-tidy. Can we have this patch merged with upcoming GA versions? or Can someone summarize what is pending in this review or what could be good alternative in v11 clang-tidy? Thank you in advance.

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

srj added a comment. This is marked as "needs revision", but it's not clear to me what the requested changes actually are. The proposed fix here may not be perfect, but AFAICT, there is simply no good way to exclude headers that are beyond your control at present. Repository: rL LLVM CHANG

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

saimusdev added a comment. Hello, Any news on accepting this feature? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

estan added a comment. It would be great to get something like this in. In our project we're currently using a kludge of overriding the `RULE_LAUNCH_COMPILE` CMake variable to insert our own shell script as the compiler. The script strips the clang-tidy invocation inserted by CMake if the sour

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

lonico added a comment. > The second way to handle this use case is possible on a different level: one > can run clang-tidy over the whole project with `-header-filter=.*` and then > filter the results and use a specialized tool to display them, e.g. > https://github.com/Ericsson/codechecker.

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

alexfh added a comment. > In our project we want to do something like include src/.*.h but exclude > src/some-thirdparty/.*.h. There are at least two other possibilities to handle this use case. The first one is to extend the way clang-tidy handles per-directory configs. Currently, for each tr

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

alexfh added a comment. I wonder whether anyone uses file patterns that need anything from regular expressions beyond `|` and `.*`. If not, globs (as used in -checks=) would be a better solution. One problem with a header-filter + exclude-header-filter is that it doesn't make it easier to expr

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

toddlipcon updated this revision to Diff 107148. toddlipcon added a comment. Regenerated patch with full context Repository: rL LLVM https://reviews.llvm.org/D34654 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTidyOptions.cp

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

alexfh added a comment. Please regenerate the patch with full context (e.g. as described in llvm.org/docs/Phabricator.html). Repository: rL LLVM https://reviews.llvm.org/D34654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

JonasToth added reviewers: aaron.ballman, alexfh, hokein. JonasToth added a comment. i added reviewers, since it seems nobody takes care of this check. remove if this was bad. Repository: rL LLVM https://reviews.llvm.org/D34654 ___ cfe-commits ma

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

toddlipcon created this revision. toddlipcon added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. This patch adds the ability to specify a regex of headers to exclude from clang-tidy diagnostics. This is the inverse of the existing header regex. In our project we want to