Prazek marked 3 inline comments as done.
Prazek added a comment.
Thanks for help. I checked and docs build and looks legit. Sorry that it took
so long.
Repository:
rL LLVM
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313278: Enable __declspec(selectany) on any platform
(authored by Prazek).
Repository:
rL LLVM
https://reviews.llvm.org/D33852
Files:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/
Prazek updated this revision to Diff 115243.
Prazek marked 8 inline comments as done.
Prazek added a comment.
Fixed links
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
aaron.ballman wrote:
> majnemer wrote:
> > aaron.ballman wro
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
majnemer wrote:
> aaron.ballman wrote:
> > Prazek wrote:
> >
majnemer added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
aaron.ballman wrote:
> Prazek wrote:
> > aaron.ballman wrote:
> >
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
Prazek wrote:
> aaron.ballman wrote:
> > Prazek wrote:
> > >
Prazek marked an inline comment as done.
Prazek added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
aaron.ballman wrote:
> Pra
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Assuming no sphinx issues with the docs, this LGTM, thank you!
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let C
Prazek updated this revision to Diff 113507.
Prazek marked 4 inline comments as done.
Prazek added a comment.
- docs fixes
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Inde
Prazek added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
aaron.ballman wrote:
> I think you need to set the `Category` as we
aaron.ballman added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:3154
+
+def SelectAnyDocs : Documentation {
+ let Content = [{This attribute makes global symbol have a weak definition
I think you need to set the `Category` as well.
To test thi
Prazek updated this revision to Diff 113359.
Prazek added a comment.
- docs fixes
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index: test/SemaCXX/attr-selectany.cpp
==
Prazek updated this revision to Diff 113357.
Prazek added a comment.
- docs fixes
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index: test/SemaCXX/attr-selectany.cpp
==
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:2477
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
let Documentation = [Undocumented];
}
Prazek wrote:
> aaron.ballman wrote:
> > aaron.ballman wrote:
> > > Since we'
Prazek added inline comments.
Comment at: include/clang/Basic/Attr.td:2477
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
let Documentation = [Undocumented];
}
aaron.ballman wrote:
> aaron.ballman wrote:
> > Since we're drastically modifying wh
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:2477
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
let Documentation = [Undocumented];
}
aaron.ballman wrote:
> Since we're drastically modifying what platforms this
Prazek updated this revision to Diff 113189.
Prazek added a comment.
- Add documentation
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index: test/SemaCXX/attr-selectany.cpp
=
Prazek added a comment.
In https://reviews.llvm.org/D33852#854213, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33852#854176, @Prazek wrote:
>
> > In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
> > >
> >
hans added a comment.
In https://reviews.llvm.org/D33852#854213, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33852#854176, @Prazek wrote:
>
> > In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
> > >
> > >
aaron.ballman added a comment.
In https://reviews.llvm.org/D33852#854176, @Prazek wrote:
> In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
> >
> > > Sorry for so late fixes, but it would be good to put it in 5.0
> >
Prazek added a comment.
In https://reviews.llvm.org/D33852#853982, @aaron.ballman wrote:
> In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
>
> > Sorry for so late fixes, but it would be good to put it in 5.0
>
>
> I do not think this should be in 5.0, as I believe we're only accepting
aaron.ballman added a comment.
In https://reviews.llvm.org/D33852#853410, @Prazek wrote:
> Sorry for so late fixes, but it would be good to put it in 5.0
I do not think this should be in 5.0, as I believe we're only accepting
regression fixes at this point.
Comment at: incl
Prazek updated this revision to Diff 112804.
Prazek added a comment.
Enable it on every platform
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
utils/TableGen/ClangAttrEmitter.cpp
Index: utils/TableGen/Clan
Prazek updated this revision to Diff 112805.
Prazek added a comment.
remove empty line
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index: test/SemaCXX/attr-selectany.cpp
===
Prazek marked 9 inline comments as done.
Prazek added a comment.
Sorry for so late fixes, but it would be good to put it in 5.0
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
rnk added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
Prazek wrote:
> d
Prazek added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
davide wrote:
davide added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
rnk wrote:
> P
rnk added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
Prazek wrote:
> r
Prazek added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
rnk wrote:
> d
rnk added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
davide wrote:
> P
davide added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
Prazek wrote:
Prazek added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
majnemer wrote
majnemer added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
selectany sh
Prazek added a comment.
I fired bug about the crash: https://bugs.llvm.org/show_bug.cgi?id=33300
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek updated this revision to Diff 101352.
Prazek added a comment.
- Fixes
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany-not-supported.c
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
utils/TableGen/ClangAttrEmitter.cpp
Ind
martell added a comment.
> ! In https://reviews.llvm.org/D33852#772290, @davide wrote:
> This assumption is not quite right. Also GCC, when targeting Linux, provides
> a `-fms-extensions` flag.
> There's a bunch of software out there that unfortunately has to target ELF
> and build with `-fms-
davide added a comment.
In https://reviews.llvm.org/D33852#772230, @martell wrote:
> @Prazek it was not disabled by mistake.
> This was a MS extension and it appeared as though the test case should have
> been for windows.
> I updated it and made the extension available to windows only. (MSVC,
martell added a comment.
@Prazek it wasn't disabled by mistake.
This was a MS extension and it appeared as though the test case should have
been for windows.
I updated it and made the extension available to windows only. (MSVC, Cygwin,
Mingw etc)
It didn't expect anyone would want a MS extension
Prazek added a comment.
It seems that this is separate issue - we don't generate comdat for MachO.
Indeed we should warn on not supported declspec for macho.
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Prazek added a comment.
OK, I will try to make it work on linux and windows only
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davide added a comment.
If you take my example, and you pass `-target x86_64-pc-win32-macho`:
On clang-3.8, `TinkyWinky` is lowered to a GV with `weak_odr` linkage:
$ clang++ 1.cpp -o - -emit-llvm -S -fms-extensions -target
x86_64-pc-win32-macho
; ModuleID = '1.cpp'
target datalayout = "e
davide added a comment.
I think lowering `__declspec(selectany)` to a `comdat` for GVs on ELF platform
is actually reasonable.
I don't know what happens on Mach-O (as far as I can tell they don't have a
real notion of COMDAT, they use coalesced symbols, but I'm not an expert of the
format so yo
Prazek created this revision.
This feature was disabled probably by mistake in
https://reviews.llvm.org/rL300562
This fixes bug https://bugs.llvm.org/show_bug.cgi?id=33285
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-sele
45 matches
Mail list logo
