[PATCH] D31492: Add `addReplacement` interface in AtomicChange.

2017-03-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 93456. hokein added a comment. Get rid of Replacement, and implement "replace" interface with range. https://reviews.llvm.org/D31492 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp Index: lib/Tooling/Ref

[PATCH] D31492: Add `addReplacement` interface in AtomicChange.

2017-03-30 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Please see comment from a previous patch (https://reviews.llvm.org/D27054?id=79099#inline-234270). Generally, `AtomicChange` is a higher level of abstraction than `Replacement`, and we don't want users to deal with `Replacement` and the related errors. https://reviews.

[PATCH] D31492: Add `addReplacement` interface in AtomicChange.

2017-03-30 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D31492 Files: include/clang/Tooling/Refactoring/AtomicChange.h lib/Tooling/Refactoring/AtomicChange.cpp Index: lib/Tooling/Refactoring/AtomicChange.cpp =