[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rG75d4d4bd028f: Add an attribute registry so plugins can add attributes (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D31338?vs=246763&id=247014#toc Repository: rG LLVM Gi

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I like this approach much better, thank you for working on it! LGTM Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:140 + /// will be normalized to

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 246763. john.brawn added a comment. Herald added a subscriber: krytarowski. This has been rewritten so that the registry is only used for attributes added by plugins, and everything else continues as before. This also removes the strange dependency I'd pr

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

aaron.ballman added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:101-103 + for (ParsedAttrInfoRegistry::iterator it = ParsedAttrInfoRegistry::begin(), +ie = ParsedAttrInfoRegistry::end(); + it != ie; ++it) { --

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/lib/Basic/Attributes.cpp:101-103 + for (ParsedAttrInfoRegistry::iterator it = ParsedAttrInfoRegistry::begin(), +ie = ParsedAttrInfoRegistry::e

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:45 +struct ParsedAttrInfo { + /// Corresponds to the Kind enum + unsigned AttrKind : 16; Please add a full stop to the end of all the comments (here and elsewhere). ===

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239536. john.brawn added a comment. Updated to match latest changes to D31337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31338/new/ https://reviews.llvm.org/D31338 Files: clang/include/clang/Sema/CMakeList

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 239295. john.brawn retitled this revision from "Move ParsedAttrInfos into a registry and point to one in AttributeList" to "Move ParsedAttrInfos into a registry and point to one in ParsedAttr". john.brawn added reviewers: erichkeane, aaron.ballman, rjmccal