aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
I like this approach much better, thank you for working on it! LGTM ================ Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:140 + /// will be normalized to gnu::attr). + std::string getFullName() const; + ---------------- This should probably be `getNormalizedFullName()` -- the full by itself implies we don't normalize, to me. ================ Comment at: clang/include/clang/Sema/ParsedAttr.h:66 + AttributeCommonInfo::Syntax Syntax; + std::string FullName; + }; ---------------- `NormalizedFullName`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31338/new/ https://reviews.llvm.org/D31338 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
