This revision was automatically updated to reflect the committed changes.
Closed by commit rL294969: [change-namespace] add an option to dump changed
files in YAML. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29893?vs=88208&id=88211#toc
Repository:
rL LLVM
https
ioeric added inline comments.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:68
+cl::opt
+DumpYAML("dump_yaml",
+ cl::desc("Dump new file content in YAML, if specified."),
hokein wrote:
> hokein wrote:
> > `dump_result` maybe a clearer nam
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:68
+cl::opt
+DumpYAML("dump_yaml",
+ cl::desc("Dump new file content in YAML, if specified."),
ioeric updated this revision to Diff 88208.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D29893
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
Index: change-namespace/tool
ioeric added inline comments.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:137
+
+ for (const auto &File : ChangedFiles) {
const auto *Entry = FileMgr.getFile(File);
hokein wrote:
> Is this duplicated as we already have "dump_results" option n
hokein added inline comments.
Comment at: change-namespace/tool/ClangChangeNamespace.cpp:68
+cl::opt
+DumpYAML("dump_yaml",
+ cl::desc("Dump new file content in YAML, if specified."),
`dump_result` maybe a clearer name, which also is consistent with c
ioeric created this revision.
Herald added a subscriber: fhahn.
https://reviews.llvm.org/D29893
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/tool/ClangChangeNamespace.cpp
Index: change-namespace/tool/ClangChangeNamespace.cpp
==
