This revision was automatically updated to reflect the committed changes.
Closed by commit rL286823: Protect std::ios tests under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26512?vs=77789&id=77797#toc
Repository:
rL LLVM
https://reviews.l
rogfer01 updated this revision to Diff 77789.
rogfer01 added a comment.
Add missing asserts as pointed out by @EricWF
https://reviews.llvm.org/D26512
Files:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp
test/std/input.output/iostreams.base/ios/basic.ios.members
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments. There are a couple of tests which don't explicitly
assert if they throw or not. Please address those tests before committing.
Comment at:
test/
rogfer01 added inline comments.
Comment at:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp:171-173
+#else
+ios1.copyfmt(ios2);
+#endif
This is a bit unexpected. It looks like if the copyfmt, even if it throws, were
able to copy
rogfer01 created this revision.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception be thrown.
https://reviews.llvm.org/D26512
Files:
test/std/input.output/iostreams.base/ios/basic.ios.members/copyfmt.pass.cpp
