EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo inline comments. There are a couple of tests which don't explicitly
assert if they throw or not. Please address those tests before committing.
================
Comment at:
test/std/input.output/iostreams.base/ios/basic.ios.members/set_rdbuf.pass.cpp:44
ios.exceptions(std::ios::badbit);
}
catch (...)
----------------
`assert(false);`
It's unrelated but it should be added.
================
Comment at:
test/std/input.output/iostreams.base/ios/iostate.flags/clear.pass.cpp:33
{
ios.exceptions(std::ios::badbit);
}
----------------
`assert(false);`
================
Comment at:
test/std/input.output/iostreams.base/ios/iostate.flags/setstate.pass.cpp:33
{
ios.exceptions(std::ios::badbit);
}
----------------
`assert(false)`
https://reviews.llvm.org/D26512
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
