srhines added a comment.
Ugh, phabricator dropped my updated commit message, so that is completely wrong
now. Oh well. I guess I will just use repo/gerrit for staging things in the
future (and get consensus there) before asking for any upstream reviews.
Repository:
rL LLVM
https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286295: Define __ANDROID_API__ for all Android builds.
(authored by srhines).
Changed prior to commit:
https://reviews.llvm.org/D26385?vs=77236&id=77250#toc
Repository:
rL LLVM
https://reviews.llvm.
eugenis accepted this revision.
eugenis added a reviewer: eugenis.
eugenis added a comment.
LGTM
https://reviews.llvm.org/D26385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert accepted this revision.
danalbert added a reviewer: danalbert.
danalbert added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
srhines updated this revision to Diff 77236.
srhines added a comment.
Switched to conditionally defining __ANDROID_API__ instead.
https://reviews.llvm.org/D26385
Files:
lib/Basic/Targets.cpp
test/Driver/android-targets.cpp
Index: test/Driver/android-targets.cpp
srhines added a comment.
In https://reviews.llvm.org/D26385#589589, @eugenis wrote:
> This is a good change, but I don't think it is the right fix for PR30940.
> Instead of handling this in the NDK, we should change *::getIRStackGuard to
> fallback to __stack_chk_guard when targeting an old ver
danalbert added a comment.
> It is defines with a value of 0. This allows you to actually do something
> better, IMO.
Can we stick with undefined? That's historically how things have been, and I'm
sure there's code out there depending on that (I had actually written a test
that would depend on
eugenis added a comment.
This is a good change, but I don't think it is the right fix for PR30940.
Instead of handling this in the NDK, we should change *::getIRStackGuard to
fallback to __stack_chk_guard when targeting an old version.
https://reviews.llvm.org/D26385
___
srhines added a comment.
In https://reviews.llvm.org/D26385#589534, @danalbert wrote:
> > This macro (along with ANDROID) should always be defined for Android
> > targets.
>
> What if only `arm-linux-androideabi` (without a version) is specified? We
> should be falling back to the old behavior
danalbert added a comment.
> This macro (along with ANDROID) should always be defined for Android targets.
What if only `arm-linux-androideabi` (without a version) is specified? We
should be falling back to the old behavior (don't defined `__ANDROID_API__`)
when that happens since that's what e
srhines created this revision.
srhines added subscribers: danalbert, eugenis, pirama, cfe-commits.
Herald added a subscriber: tberghammer.
Bug: https://llvm.org/bugs/show_bug.cgi?id=30940
This macro (along with __ANDROID__) should always be defined for Android
targets. We set it to the major (onl
11 matches
Mail list logo
