This revision was automatically updated to reflect the committed changes.
Closed by commit rL286228: [clang-tidy] Improve rename_check.py. (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D25074?vs=77168&id=77169#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2507
omtcyfz updated this revision to Diff 77168.
omtcyfz added a comment.
Addressing comments Alex made about line breaks.
https://reviews.llvm.org/D25074
Files:
clang-tidy/rename_check.py
Index: clang-tidy/rename_check.py
===
--- c
omtcyfz added inline comments.
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- header_guard_new = module.upper() + '_' +
check_name_new.upper().replace('-', '_')
+ header_guard_old = args.module.u
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
One nit. Otherwise looks good. Thank you!
Comment at: clang-tidy/rename_check.py:89
- header_guard_old = module.upper() + '_' + check_name.upper().replace('-',
'_')
- he
omtcyfz updated this revision to Diff 76593.
omtcyfz added a comment.
Reversed "tabwidth:2 -> tabwidth:4" change.
Removed unused dependency (`re`).
Got rid of `sys.argv[0]` via using Pythonic `__file__` and removed (now)
redundant dependency (`sys`).
https://reviews.llvm.org/D25074
Files:
cl
alexfh requested changes to this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision now requires changes to proceed.
Kirill, if you still have time for this, could you submit reformatting as a
separate patch to make semantic changes more visible?
https://reviews.ll
