mgorny planned changes to this revision.
mgorny added a comment.
I will be reworking this to use CMake's PRIVATE and PUBLIC linked libs
consistently across the build, linker scripts and possibly tests.
@EricWF, would you prefer if I killed the `add_library_flags*` macros or
extended them to sup
mgorny added a comment.
In https://reviews.llvm.org/D25008#555041, @rmaprath wrote:
> The patch generally makes sense to me.
>
> I wonder if the test configuration can also benefit from this;
> `test/libcxx/test/target_info.py` manually updates the link line to use
> `-lgcc_s` or `-lunwind` dep
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
The patch generally makes sense to me.
I wonder if the test configuration can also benefit from this;
`test/libcxx/test/target_info.py` manually updates the link line to use
`-lgcc_s` or `-lunwind` depending on how the build is co
mgorny created this revision.
mgorny added a reviewer: EricWF.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mgorny, beanz.
Include an appropriate unwinder library (-lunwind or -lgcc_s) when constructing
a linker script for libc++. This is necessary since otherwise clang++ set
