Re: [PATCH] D24446: Implement revision to LWG#2758

2016-09-24 Thread Marshall Clow via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Landed as revision 282342. Comment at: include/string:613 @@ +612,3 @@ + ( is_convertible >::value && + !is_convertible::value)) {}; + EricWF wrote: > The discussion for LWG 2758 gives a `

Re: [PATCH] D24446: Implement revision to LWG#2758

2016-09-15 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The new overloads taking string_view's need to guard against self-aliasing string_views. Once that is fixed I would double check that your tests for `!is_convertible<_Tp const&, const _CharT*>

Re: [PATCH] D24446: Implement revision to LWG#2758

2016-09-11 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string:615 @@ +614,3 @@ + +// template +// struct __can_be_converted_to_string_view : public _LIBCPP_BOOL_CONSTANT( These bits will be removed. Comment at: test/std/strings/basic.string/str