mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 282342.
================
Comment at: include/string:613
@@ +612,3 @@
+ ( is_convertible<const _Tp&, basic_string_view<_CharT, _Traits>
>::value &&
+ !is_convertible<const _Tp&, const _CharT*>::value)) {};
+
----------------
EricWF wrote:
> The discussion for LWG 2758 gives a `replace` test case for this condition.
> Could you add that test to our suite?
I think I have an equivalent test - passing a non-const char * .
That should be about line 5994 of string_replace/size_size_T_size_size.pass.cpp
https://reviews.llvm.org/D24446
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
