Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-16 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman closed this revision. aaron.ballman added a comment. Thank you! I've commit in r278812. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread Eugene via cfe-commits
kevgs added a comment. I have no commit rights. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread Eugene via cfe-commits
kevgs updated this revision to Diff 67955. kevgs added a comment. clang-formatted + dead code removed https://reviews.llvm.org/D23329 Files: include/clang/AST/AttrIterator.h Index: include/clang/AST/AttrIterator.h === --- includ

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-12 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer accepted this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/AST/AttrIterator.h:42 @@ -41,3 +41,3 @@ /// AttrVec - A vector

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-09 Thread Eugene via cfe-commits
kevgs added a comment. Btw, ConstAttrVec is never used. https://reviews.llvm.org/D23329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-09 Thread Eugene via cfe-commits
kevgs added a comment. My test case is: clang++ -std=c++14 -fsyntax-only test.cc #include #include #include int main() { std::vector v = {1, 2, 3}; std::for_each(v.begin(), v.end(), [](auto i) { std::cout << i; }); return 0; } https://reviews.llvm.org/D23329 _

[PATCH] D23329: [NFC] Reducing allocations in AST attributes

2016-08-09 Thread Eugene via cfe-commits
kevgs created this revision. kevgs added reviewers: rsmith, bkramer. kevgs added a subscriber: cfe-commits. In my test case max resident memory changed from 65760k to 64476k which is 1.9% improvement. Allocations in grow_pod changed from 8847 to 4872 according to tcmalloc heap profiler. Overa