anemet updated this revision to Diff 70502.
anemet added a comment.
This renames the flag to -fdiagnostics-show-hotness as requested by Richard.
Also added the missing documentation bits.
https://reviews.llvm.org/D23284
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.t
anemet added a comment.
In https://reviews.llvm.org/D23284#535258, @rsmith wrote:
> I think this should start with `-fdiagnostics` to group it with other similar
> flags. `-fdiagnostics-include-hotness-in-remarks` seems too specific to me --
> I could imagine generating warnings from the middle
rsmith added a comment.
In https://reviews.llvm.org/D23284#534919, @anemet wrote:
> In https://reviews.llvm.org/D23284#534879, @rsmith wrote:
>
> > I think this should not be an -R option at all; like -W flags, the idea is
> > for -R to only act as a filter for which diagnostics are shown. This
anemet added a comment.
In https://reviews.llvm.org/D23284#534879, @rsmith wrote:
> I think this should not be an -R option at all; like -W flags, the idea is
> for -R to only act as a filter for which diagnostics are shown. This option
> seems much more closely related to options like -fdiagno
rsmith added a comment.
Sorry I missed this until now.
I think this should not be an -R option at all; like -W flags, the idea is for
-R to only act as a filter for which diagnostics are shown. This option seems
much more closely related to options like -fdiagnostics-show-option and
-fdiagnost
anemet added a comment.
In https://reviews.llvm.org/D23284#526413, @dnovillo wrote:
> I'm fine with it, but I don't have much of a say in how option groups are
> organized. If Richard agrees, then it LGTM.
Ping. Would it be OK to commit this with the two LGTMs? I am around to fix
any fall-
anemet added a comment.
@dnovillo or @rsmith, can you please confirm if you agree that this new option
-Rpass-with-hotness should not be part of R_group. R_group options
enable/disable groups of remarks whereas this one is only modifying the text of
the remarks. Thanks!
https://reviews.llvm
dnovillo added a comment.
In https://reviews.llvm.org/D23284#526389, @anemet wrote:
> @dnovillo or @rsmith, can you please confirm if you agree that this new
> option -Rpass-with-hotness should not be part of R_group. R_group options
> enable/disable groups of remarks whereas this one is only
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM, but you should wait for confirmation on the behavior of the R_Group
behavior from @dnovillo or @rsmith before committing.
https://reviews.llvm.org/D23284
_
anemet updated this revision to Diff 67653.
anemet added a comment.
Since -Rpass-with-hotness is not part of R_group, we need to manually forward
it to clang -cc1. I've also extended the test to cover this bug.
https://reviews.llvm.org/D23284
Files:
include/clang/Basic/DiagnosticDriverKinds.
anemet added reviewers: dnovillo, rsmith.
anemet marked an inline comment as done.
anemet added subscribers: dnovillo, rsmith.
anemet added a comment.
Add more reviewers suggested by Aaron. @dnovillo, @rsmith, is my thinking
correct that this new flag does not belong to the R_Group.
https://re
anemet updated this revision to Diff 67379.
anemet added a comment.
Address Aaron's comment
https://reviews.llvm.org/D23284
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CodeGenAction.cpp
lib/F
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:186
@@ +185,3 @@
+def warn_drv_argument_requires : Warning<
+ "argument '%0' requires %1">,
+ InGroup;
Given that there's only one driver option that requires this diag
anemet created this revision.
anemet added reviewers: hfinkel, rjmccall, aaron.ballman.
anemet added a subscriber: cfe-commits.
I've recently added the ability for optimization remarks to include the
hotness of the corresponding code region. This uses PGO and allows
filtering of the optimization
14 matches
Mail list logo
