aaron.ballman added inline comments.

================
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:186
@@ +185,3 @@
+def warn_drv_argument_requires : Warning<
+  "argument '%0' requires %1">,
+  InGroup<UnusedCommandLineArgument>;
----------------
Given that there's only one driver option that requires this diagnostic, I 
would replace the %0 and %1 directives with their hard-coded text for right now 
(unless you plan on needing this generality in the near future). If we need to 
generalize the diagnostic in the future, we can do so using a %select directive.


https://reviews.llvm.org/D23284



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to