Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

This revision was automatically updated to reflect the committed changes. Closed by commit rL279378: [analyzer] Use faster hashing (MD5) in CloneDetector. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D22515?vs=68778&id=68784#toc Repository: rL LLVM https://revi

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor marked an inline comment as done. teemperor added a comment. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor updated this revision to Diff 68778. teemperor added a comment. - Replaced hash_stream with MD5 in the sub-sequence code. https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneChecker.cpp

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

NoQ added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:550 @@ -548,2 +549,3 @@ CloneDetector::CloneSignature SubSignature; +llvm::hash_stream SubHash; Hmm, this still uses `hash_stream`. https://reviews.llvm.org/D22515 _

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor updated this revision to Diff 68632. teemperor added a comment. This revision is now accepted and ready to land. - Moved from hash_stream to LLVM's MD5 implementation. https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor planned changes to this revision. teemperor added a comment. - As the hash_stream patch will take a while to land upstream, we will change this to use FoldingSetNodeID and change it to hash_stream once that landed. https://reviews.llvm.org/D22515 ___

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor marked 2 inline comments as done. teemperor added a comment. https://reviews.llvm.org/D22515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor updated this revision to Diff 68170. teemperor added a comment. - Renamed FoldingSetWrapper to FoldingSetNodeIDWrapper - Added missing // end anonymous namespace https://reviews.llvm.org/D22515 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/St

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

NoQ added a comment. Considering the refactoring planned in https://reviews.llvm.org/D23418, i've no more comments on the part of the code that isn't rewritten in the subsequent review. I like how the new hashing system is put to work here. Comment at: lib/Analysis/CloneDetect

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor retitled this revision from "Added false-positive filter for unintended hash code collisions to the CloneDetector." to "[analyzer] Added custom hashing to the CloneDetector.". teemperor updated the summary for this revision. teemperor updated this revision to Diff 67715. teemperor added