NoQ added a comment.
Considering the refactoring planned in https://reviews.llvm.org/D23418, i've no
more comments on the part of the code that isn't rewritten in the subsequent
review. I like how the new hashing system is put to work here.
================
Comment at: lib/Analysis/CloneDetection.cpp:565
@@ +564,3 @@
+/// argument of the StmtDataCollector.
+class FoldingSetWrapper {
+
----------------
Hmm. `FoldingSetNodeIDWrapper`? Because in fact we're wrapping neither a set,
nor a node, but only an ID.
================
Comment at: lib/Analysis/CloneDetection.cpp:576
@@ +575,3 @@
+};
+}
+
----------------
`// end anonymous namespace`?
https://reviews.llvm.org/D22515
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
