I looked at r278501 and realized it’s doing more than just fixing the test case
in PR28288. For example, when the following code was compiled,
vi8 = vi8 << vuc8; // vuc8: <8 x unsigned char>, vi8: <8 x int>
vc8 = vc8 << vs4; // vc8: <8 x char>, vs4: <4 x short>
prior to r278501, clang would re
Thanks, I’ll take a look at your patch today.
vec1.patch
Description: Binary data
> On Sep 7, 2016, at 12:53 AM, Vladimir Yakovlev wrote:
>
> I did another fix (attached). It fixes the error and chang-check has not any
> new errors. Please take a look.
>
> Where can I see your fix?
>
>
>
ladimir
>>
>>
>>
>> -------------------
>>
>> From: Akira Hatanaka mailto:ahata...@gmail.com>>
>> Date: Fri, Sep 2, 2016 at 3:00 AM
>> Subject: Re: [PATCH] D21678: Fix For pr28
kira Hatanaka mailto:ahata...@gmail.com>>
> Date: Fri, Sep 2, 2016 at 3:00 AM
> Subject: Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of
> vector values
> To: vladimi...@gmail.com <mailto:vladimi...@gmail.com>,
> ulrich.weig...@de.ibm.com <mailto
I'll fix this.
Vladimir
---
From: *Akira Hatanaka*
Date: Fri, Sep 2, 2016 at 3:00 AM
Subject: Re: [PATCH] D21678: Fix For pr28288 - Error message in shift of
vector values
To: vladimi...@gmail.com, ulrich
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
This patch causes clang to error out on the following code, which used to
compile fine:
$ cat f2.c
typedef __attribute__((__ext_vector_type__(8))) unsigned short vector_ushort8;
vector_ushort8 foo1(void) {
return 1 << (
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278501: Fix For pr28288 - Error message in shift of vector
values (authored by asbokhan).
Changed prior to commit:
https://reviews.llvm.org/D21678?vs=67140&id=67820#toc
Repository:
rL LLVM
https://r
andreybokhanko added a subscriber: andreybokhanko.
andreybokhanko added a comment.
@uweigand Ulrich, any objections here? If not, I will commit this patch
tomorrow (as the author, Vladimir, doesn't have commit access yet).
Andrey
Repository:
rL LLVM
https://reviews.llvm.org/D21678
__
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, but I am also not well-versed in vector operations, so you may want to
wait a day or two for @uweigand or someone else to sign off as well.
Comment at: ll
vbyakovl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
}
-return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
- /*AllowBothBool*/true,
- /*AllowBool
aaron.ballman added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8681-8683
@@ -8680,5 +8676,3 @@
}
-return CheckVectorOperands(LHS, RHS, Loc, IsCompAssign,
- /*AllowBothBool*/true,
- /*Allo
vbyakovl added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8597
@@ -8596,4 +8596,3 @@
///by a scalar or vector shift amount.
-static QualType checkOpenCLVectorShift(Sema &S,
- ExprResult &LHS, ExprResult &RHS,
vbyakovl set the repository for this revision to rL LLVM.
vbyakovl updated this revision to Diff 67140.
Repository:
rL LLVM
https://reviews.llvm.org/D21678
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/Sema/shift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
==
aaron.ballman added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8597
@@ -8596,4 +8596,3 @@
///by a scalar or vector shift amount.
-static QualType checkOpenCLVectorShift(Sema &S,
- ExprResult &LHS, ExprResult &
vbyakovl added a comment.
Someone, please review this.
https://reviews.llvm.org/D21678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vbyakovl added a comment.
Ping!
https://reviews.llvm.org/D21678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vbyakovl updated this revision to Diff 62464.
http://reviews.llvm.org/D21678
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/Sema/shift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
===
--- llvm/tools/clang
Anastasia added a subscriber: Anastasia.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8595
@@ -8594,3 +8594,3 @@
-/// \brief Return the resulting type when an OpenCL vector is shifted
+/// \brief Return the resulting type when an vector is shifted
///by a scalar o
vbyakovl updated this revision to Diff 62345.
http://reviews.llvm.org/D21678
Files:
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/Sema/shift.c
Index: llvm/tools/clang/lib/Sema/SemaExpr.cpp
===
--- llvm/tools/clang
19 matches
Mail list logo
