This revision was automatically updated to reflect the committed changes.
Closed by commit rL272004: [include-fixer] try to make vim header selection
more friendly. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D21019?vs=59858&id=59871#toc
Repository:
rL LLVM
http:/
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg then.
http://reviews.llvm.org/D21019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
ioeric added a comment.
As per our offline discussion, `getchar()` does not work with options with more
than 2 digits (e.g. index number > 9). I'll keep it as it is now until we come
up with a better solution.
http://reviews.llvm.org/D21019
___
cf
ioeric updated this revision to Diff 59858.
ioeric added a comment.
- fixed a bug with index.
http://reviews.llvm.org/D21019
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-fixer.py
===
-
bkramer added a comment.
Nice! Can we somehow make the user not press enter after putting in the number?
getchar() maybe?
http://reviews.llvm.org/D21019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
ioeric updated this revision to Diff 59722.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed reviewer's comments.
http://reviews.llvm.org/D21019
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-fixer.py
=
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.py:53
@@ +52,3 @@
+ except Exception:
+if res == '':
+ # choose the top ranked header by default
We can handle the ` ` , `a`, `q` cases after `res=vim.eval(to_eval)` instead
ioeric created this revision.
ioeric added reviewers: bkramer, hokein.
ioeric added a subscriber: cfe-commits.
use 'input()' to get user's input so that we can support more options.
http://reviews.llvm.org/D21019
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang
