hokein added inline comments. ================ Comment at: include-fixer/tool/clang-include-fixer.py:53 @@ +52,3 @@ + except Exception: + if res == '': + # choose the top ranked header by default ---------------- We can handle the ` ` , `a`, `q` cases after `res=vim.eval(to_eval)` instead of handling them in exception block. They don't look like errors in my opinion.
================ Comment at: include-fixer/tool/clang-include-fixer.py:132 @@ +131,3 @@ + except Exception as error: + print error.message + return ---------------- For error message, it might be better to print to stderr `print >> sys.stderr, error.message`? http://reviews.llvm.org/D21019 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
