hans added a comment.
In http://reviews.llvm.org/D20576#438581, @Ilod wrote:
> It seems the new test was commited as .cc instead of .c, which changes the
> name mangling, making // NOINLINE-LABEL: @foo fail.
> Either the file should be renamed, or -x c should be added to clang
> invocation, or
Ilod added a comment.
Hello,
It seems the new test was commited as .cc instead of .c, which changes the name
mangling, making // NOINLINE-LABEL: @foo fail.
Either the file should be renamed, or -x c should be added to clang invocation,
or LABEL check updated.
Repository:
rL LLVM
http://rev
hans added a subscriber: majnemer.
hans added a comment.
majnemer reminded me that /O options can be combined, so e.g. /Odb2 would be a
valid combination. I've followed up with r270614 to move the /Ob flags into
that mechanism.
Repository:
rL LLVM
http://reviews.llvm.org/D20576
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL270609: [Driver] Add support for -finline-functions and /Ob2
flags (authored by hans).
Changed prior to commit:
http://reviews.llvm.org/D20576?vs=58302&id=58308#toc
Repository:
rL LLVM
http://review
Ilod added a comment.
I don't have commit access, so you can do it for me, thanks.
http://reviews.llvm.org/D20576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me!
Do you have commit access, or would you like me to commit this for you?
http://reviews.llvm.org/D20576
___
cfe-commits mailing lis
Ilod updated this revision to Diff 58302.
Ilod added a comment.
Thanks!
Updated to respect the 80-columns limit.
Updated the tests to have a clearer checks. (I don't know well the FileCheck,
so I took example from test/CodeGen/noinline.c, but this is indeed more
comprehensible).
http://review
hans added a comment.
Thanks! Some comments below:
Comment at: lib/Driver/Tools.cpp:5335
@@ -5334,3 +5334,3 @@
- if (Args.hasArg(options::OPT_fno_inline_functions))
-CmdArgs.push_back("-fno-inline-functions");
+ if (Arg* InlineArg = Args.getLastArg(options::OPT_finline_f
Ilod created this revision.
Ilod added a reviewer: hans.
Ilod added a subscriber: cfe-commits.
-finline-functions and /Ob2 are currently ignored by Clang. The only way to
enable inlining is to use the global O flags, which also enable other options,
or to emit LLVM bitcode using Clang, then runn
