hans added a comment.

In http://reviews.llvm.org/D20576#438581, @Ilod wrote:

> It seems the new test was commited as .cc instead of .c, which changes the 
> name mangling, making // NOINLINE-LABEL: @foo fail.
>  Either the file should be renamed, or -x c should be added to clang 
> invocation, or LABEL check updated.


Sigh, I'm not getting many points today.

I renamed the test because when I tried it, the inline_hint() function didn't 
get inlined in C mode, but it did in C++ mode. But in so doing, I renamed it to 
.cc, which means the test didn't run at all (it should be .cpp), which is why I 
didn't notice that the test doesn't pass.

The reason inlining didn't happen was probably because I ran the test for a 
different target than you did. Which reminds me, the test needs to specify a 
target triple.

Hopefully I managed to make things right in r270633


Repository:
  rL LLVM

http://reviews.llvm.org/D20576



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to