Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-31 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271275: [ARM] Add load/store co-processor intrinsics. (authored by rsingh). Changed prior to commit: http://reviews.llvm.org/D20563?vs=58314&id=59055#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Tim Northover via cfe-commits
t.p.northover accepted this revision. t.p.northover added a reviewer: t.p.northover. t.p.northover added a comment. This revision is now accepted and ready to land. Thanks Ranjeet. LGTM! Tim. http://reviews.llvm.org/D20563 ___ cfe-commits mailing l

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs marked an inline comment as done. rs added a comment. Tim thanks for reviewing this patch. I've uploaded a new one with your suggested change. If I don't respond to any further comments after today it'll be because I'm on holiday and won't be back till next week. http://reviews.llvm.org/D20

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs updated this revision to Diff 58314. http://reviews.llvm.org/D20563 Files: include/clang/Basic/BuiltinsARM.def test/CodeGen/builtins-arm.c test/Sema/builtins-arm.c Index: test/Sema/builtins-arm.c === --- test/Sema/builtins-

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Tim Northover via cfe-commits
t.p.northover added a subscriber: t.p.northover. t.p.northover added a comment. Just one suggestion for the tests here: Comment at: test/Sema/builtins-arm.c:50 @@ -49,2 +49,3 @@ void test6(int a, int b, int c) { + __builtin_arm_ldc(a, 2, &a); // expected-error {{argument to

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs added a comment. LLVM part of the patch is here http://reviews.llvm.org/D20564 http://reviews.llvm.org/D20563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs created this revision. rs added a reviewer: rengolin. rs added a subscriber: cfe-commits. Patch adds intrinsics for ldc, ldcl, ldc2, ldc2l, stc, stcl, stc2 and stc2l. http://reviews.llvm.org/D20563 Files: include/clang/Basic/BuiltinsARM.def test/CodeGen/builtins-arm.c test/Sema/builtins