timshen added a comment.
...and r274396 to remove all of the checks for symbolic labels, which are not
generated by release builds, nor controlled by a runtime-flag.
Repository:
rL LLVM
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
timshen added a comment.
Also committed r274387 to remove unnecessary CHECks. It seems to cause problems
in certain platforms.
Repository:
rL LLVM
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
This revision was automatically updated to reflect the committed changes.
timshen marked an inline comment as done.
Closed by commit rL274385: [Temporary, Lifetime] Add lifetime marks for
temporaries (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D20499?vs=62433&id=6254
timshen updated this revision to Diff 62433.
timshen added a comment.
Done. Added a new testcase to ensure the correct behavior with exceptions
turned on.
http://reviews.llvm.org/D20499
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFu
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:438
@@ -426,1 +437,3 @@
+}
EmitAnyExprToMem(E, Object, Qualifiers(), /*IsInit*/true);
+if (Size) {
Seems like you should push the cleanup before you emit the initializer; the
cleanup sh
timshen added a comment.
I'm looking at some internal test failures caused by this patch.
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added a comment.
Is anything blocking us on this review?
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen marked an inline comment as done.
timshen added a comment.
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen updated this revision to Diff 58734.
timshen added a comment.
Herald added a subscriber: klimek.
Used pushFullExprCleanup.
microsoft-abi-eh-cleanups.cpp fails because each pushFullExprCleanup introduces
a new cleanup.cond variable, even if that pushFullExprCleanup is just for
lifetime m
timshen updated this revision to Diff 58738.
timshen added a comment.
Upload the rebased patch.
http://reviews.llvm.org/D20499
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/EHScopeStack.h
test/CodeGen/tempora
timshen updated this revision to Diff 58737.
timshen added a comment.
Upload the rebased patch.
http://reviews.llvm.org/D20499
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Sema/CleanupInfo.h
include/clang/Sema/ScopeInfo.h
include/clang/Sema/Sema.h
lib/AS
rsmith added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:446
@@ +445,3 @@
+ case SD_FullExpression:
+EHStack.pushCleanup(NormalEHLifetimeMarker, Object,
+ Size);
This should use pushFullExprCleanup.
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
With all MaterializeTemporaryExprs coming with a ExprWithCleanups, it's
easy to add correct lifetime.end marks into the right RunCleanupsScope.
http://reviews.llvm.org/D20499
Files:
lib/Co
13 matches
Mail list logo
