Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-31 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265006: [OpenCL] Added nosvm attribute for OpenCL v2.0. (authored by stulova). Changed prior to commit: http://reviews.llvm.org/D17861?vs=52077&id=52185#toc Repository: rL LLVM http://reviews.llvm.o

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-30 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 52077. yaxunl marked an inline comment as done. yaxunl added a comment. Insert an empty line to the test for clarity. http://reviews.llvm.org/D17861 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKi

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-30 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM, except for one tiny comment that can be addressed before committing. Comment at: test/SemaOpenCL/nosvm.cl:11 @@ +10,3 @@ +// expected-warning@-4 {{'nosvm' attribute is deprecated and ignored in OpenCL version 2.

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-29 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! http://reviews.llvm.org/D17861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-29 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 51967. yaxunl marked 2 inline comments as done. yaxunl added a comment. Revised as Aaron suggested. http://reviews.llvm.org/D17861 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-28 Thread Aaron Ballman via cfe-commits
aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: lib/Sema/SemaDeclAttr.cpp:5210 @@ +5209,3 @@ +static void handleOpenCLNoSVMAttr(Sema &S, Decl *D, const AttributeList &Attr) { + if (!S.LangOpts.OpenCL) { +S.Diag(Att

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-28 Thread Yaxun Liu via cfe-commits
yaxunl removed rL LLVM as the repository for this revision. yaxunl updated this revision to Diff 51821. yaxunl marked 4 inline comments as done. yaxunl added a comment. Revised by Aaron's and Anastasia's comments. Changed error/warning message for invalid usage of nosvm attribute. http://review

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-28 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; yaxunl wrote: > aaron.ballman wrote: > > yaxunl wrote: > > > aaron.ballman wrote: > > > > Since the

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-22 Thread Yaxun Liu via cfe-commits
yaxunl marked an inline comment as done. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; aaron.ballman wrote: > yaxunl wrote: > > aaron.ballman wrote: > > > Since the attribute is ignor

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; yaxunl wrote: > aaron.ballman wrote: > > Since the attribute is ignored by clang, you should inherit

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-09 Thread Yaxun Liu via cfe-commits
yaxunl marked 7 inline comments as done. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; aaron.ballman wrote: > Since the attribute is ignored by clang, you should inherit from IgnoredA

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-09 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. Comment at: include/clang/Basic/Attr.td:701 @@ -699,1 +700,3 @@ +def OpenCLNoSVM : Attr { + let Spellings = [GNU<"nosvm">]; Since the attribute is ignored by clang,

Re: [PATCH] D17861: [OpenCL] Accept __attribute__((nosvm))

2016-03-09 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/SemaOpenCL/nosvm.cl:9 @@ +8,3 @@ +#else +void f(__attribute__((nosvm)) int* a); // expected-warning {{'nosvm' attribute ignored}} +#endif yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > > > yaxunl wrote: > >