Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-20 Thread Ben Craig via cfe-commits
bcraig closed this revision. bcraig added a comment. r270213 http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-17 Thread Ben Craig via cfe-commits
bcraig added a comment. I'll be submitting this Friday morning, barring any objections (I'm out of the office the next couple of days). http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-17 Thread Ben Craig via cfe-commits
bcraig updated this revision to Diff 57521. bcraig marked 2 inline comments as done. http://reviews.llvm.org/D17416 Files: include/support/android/locale_bionic.h include/support/newlib/xlocale.h include/support/xlocale/__posix_l_fallback.h include/support/xlocale/__strtonum_fallback.h

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-17 Thread Ben Craig via cfe-commits
bcraig updated this revision to Diff 57520. http://reviews.llvm.org/D17416 Files: include/support/android/locale_bionic.h include/support/newlib/xlocale.h include/support/xlocale/__posix_l_fallback.h include/support/xlocale/__strtonum_fallback.h include/support/xlocale/xlocale.h Index:

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-16 Thread Dan Albert via cfe-commits
danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM. Sorry for the delay in response. http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-05-16 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. A couple of packaging comments. In general, this looks fine to me - still waiting on someone from Android to chime in. -- I'll ping Dan. Comment at: include/support/xlocale/__posix_l_fallback.h:13 @@ +12,3 @@ +// extended locale support for libc's

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-04-26 Thread Ben Craig via cfe-commits
bcraig added a comment. ping @danalbert, @mclow.lists http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-03-29 Thread Ben Craig via cfe-commits
bcraig added a comment. ping @danalbert, @mclow.lists http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-03-09 Thread Ben Craig via cfe-commits
bcraig added a comment. ping @danalbert http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

2016-02-22 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. This looks fine to me; but I want to hear from @danalbert. http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits