hokein marked 3 inline comments as done.
Comment at: clang-tidy/misc/IncorrectRoundings.cpp:39
@@ +38,3 @@
+namespace tidy {
+void IncorrectRoundings::registerMatchers(MatchFinder *MatchFinder) {
+ // Match a floating literal with value 0.5.
Done. The `ASTMatcher
hokein updated this revision to Diff 46539.
hokein added a comment.
Address Alex's comments.
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/IncorrectRoundings.h
clang-tidy/misc/MiscTidyModule.cpp
docs/clang-t
alexfh added a comment.
Nice! See a few comments inline.
Comment at: clang-tidy/misc/IncorrectRoundings.cpp:38
@@ +37,3 @@
+ // Match a floating point expression.
+ auto FloatType = expr(anyOf(hasType(qualType(asString("long double"))),
+ hasType(q
hokein updated this revision to Diff 46515.
hokein added a comment.
Update
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/IncorrectRoundings.h
clang-tidy/misc/MiscTidyModule.cpp
docs/clang-tidy/checks/list.rs
hokein created this revision.
hokein added a reviewer: alexfh.
hokein added subscribers: jpienaar, cfe-commits.
This is originally implemented by Jacques Pienaar.
http://reviews.llvm.org/D16764
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/IncorrectRoundings.cpp
clang-tidy/misc/Inc
