This revision was automatically updated to reflect the committed changes.
Closed by commit rL260712: [clang-tidy] Add check
performance-faster-string-find (authored by sbenza).
Changed prior to commit:
http://reviews.llvm.org/D16152?vs=47808&id=47825#toc
Repository:
rL LLVM
http://reviews.l
sbenza updated this revision to Diff 47808.
sbenza marked an inline comment as done.
sbenza added a comment.
Minor fix on comment
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tidy/performance/FasterStrin
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with one tiny nit.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:44
@@ +43,3 @@
+ }
+ // Now replace the " with '
+ auto pos = Result.find
sbenza added a comment.
Friendly ping.
http://reviews.llvm.org/D16152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza updated this revision to Diff 46798.
sbenza added a comment.
Make the delimiter a constant and fix mismatch between parse/serialize of the
option.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tid
sbenza updated this revision to Diff 46796.
sbenza added a comment.
Added comment about StringLikeClasses
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tidy/performance/FasterStringFindCheck.h
clang-tid
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:30
@@ +29,3 @@
+Class = Class.trim();
+if (!Class.empty())
+ Result.push_back(Class);
alexfh wrote:
> aaron.ballman wrote:
> > > Also changed the separat
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:30
@@ +29,3 @@
+Class = Class.trim();
+if (!Class.empty())
+ Result.push_back(Class);
aaron.ballman wrote:
> > Also changed the separator to be ';' instead of '
hokein added a subscriber: hokein.
Comment at: clang-tidy/performance/FasterStringFindCheck.h:25
@@ +24,3 @@
+/// The character literal overload is more efficient.
+///
+/// For the user-facing documentation see:
I think you need to add document about `StringLikeC
sbenza added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29
@@ +28,3 @@
+Class = Class.trim();
+ return std::vector(Classes.begin(), Classes.end());
+}
aaron.ballman wrote:
> I think hasName() will assert if given an empty st
sbenza updated this revision to Diff 44901.
sbenza marked an inline comment as done.
sbenza added a comment.
More checks in argument parsing.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tidy/performance
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:29
@@ +28,3 @@
+Class = Class.trim();
+ return std::vector(Classes.begin(), Classes.end());
+}
I think hasName() will assert if given an empty string, so this sh
sbenza marked 2 inline comments as done.
sbenza added a comment.
http://reviews.llvm.org/D16152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza updated this revision to Diff 44889.
sbenza marked 2 inline comments as done.
sbenza added a comment.
Added support for non 'char' chars.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
clang-tidy/performa
sbenza marked an inline comment as done.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:51
@@ +50,3 @@
+ const auto StringFindFunctions =
+ anyOf(hasName("find"), hasName("rfind"), hasName("find_first_of"),
+hasName("find_first_not_of"), hasName("fi
sbenza updated this revision to Diff 44886.
sbenza marked 4 inline comments as done.
sbenza added a comment.
Added template and macro tests.
Fixed warning message.
http://reviews.llvm.org/D16152
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/FasterStringFindCheck.cpp
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
aaron.ballman wrote:
> alexfh wrote:
> > aaron.b
aaron.ballman added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
alexfh wrote:
> aaron.ballman wrote:
> >
alexfh added inline comments.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
aaron.ballman wrote:
> It might be nice for this
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:25
@@ +24,3 @@
+ SmallVector Classes;
+ Option.split(Classes, ",");
+ return std::vector(Classes.begin(), Classes.end());
alexfh added a comment.
Awesome! See a few comments inline.
Comment at: clang-tidy/performance/FasterStringFindCheck.cpp:51
@@ +50,3 @@
+ const auto StringFindFunctions =
+ anyOf(hasName("find"), hasName("rfind"), hasName("find_first_of"),
+hasName("find_first_
sbenza created this revision.
sbenza added a reviewer: alexfh.
sbenza added a subscriber: cfe-commits.
Add check performance-faster-string-find.
It replaces single character string literals to character literals in calls to
string::find and friends.
http://reviews.llvm.org/D16152
Files:
clang
22 matches
Mail list logo
