[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev added a subscriber: lkail. v.g.vassilev added a comment. In D159115#4642111 , @tuliom wrote: > In D159115#4641834 , @mgorny wrote: > >> Is that actually a regression, or merely the test wasn't checkin

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. In D159115#4641834 , @mgorny wrote: > Is that actually a regression, or merely the test wasn't checking it before? I can't tell because the test didn't exist before. > My educated guess would be that the code in the test redefine

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. > Did Gentoo switch the default long double to IEEE 128-bit floating point? `LDBL_MANT_DIG` is 106, so I guess not yet on this system. > glibc provides 2 printf implementations on ppc64le (different symbols). The > headers control which implementation is used. Is that a

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. Let me elaborate my previous comment... I'm using Fedora, which has switched the default long double on ppc64le to IEEE 128-bit floating point. glibc provides 2 printf implementations on ppc64le (different symbols). The headers control which implementation is used. I won

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. In D159115#4640388 , @mgorny wrote: > I'm sorry, by "new" you mean the version with `uintptr_t` or the original as > well? Both with `uintptr_t` as well as `unsigned long long`. In D159115#4641721

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I've tested right now (as of 3398744a6106c83993611bd3c5e79ec6b94417dc ) and all c

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. In D159115#4640154 , @tuliom wrote: > This new test does not work on ppc64le. I'm sorry, by "new" you mean the version with `uintptr_t` or the original as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. This new test does not work on ppc64le. The returned addresses are different: Expected equality of these values: (uintptr_t)&printf Which is: 140735424286016 Addr->getValue() Which is: 140735424167152 Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Thank you both! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

thesamesam added a comment. In D159115#4638325 , @v.g.vassilev wrote: > In D159115#4638323 , @mgorny wrote: > >> Changing the type from `unsigned long long` to `uintptr_t` fix the test for >> me. > > Ah! Nice ca

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev added a comment. In D159115#4638323 , @mgorny wrote: > Changing the type from `unsigned long long` to `uintptr_t` fix the test for > me. Ah! Nice catch! Can you commit the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. Changing the type from `unsigned long long` to `uintptr_t` fix the test for me. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:246 + EXPECT_FALSE(!Addr); + EXPECT_EQ((unsigned long long)&printf, Addr->getValue()); } Re

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

mgorny added a comment. This change is causing test regressions on 32-bit architectures (I've reproduced with `-m32` on amd64 and in 32-bit nspawn container on arm64): FAIL: Clang-Unit :: Interpreter/./ClangReplInterpreterTests/1/13 (1 of 1584) TEST 'Clang-Unit :: Inter

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG196d8569d46d: [clang-repl] Adapt to the recent dylib-related changes in ORC. (authored by v.g.vassilev). Herald added a project: clang. Repository:

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev updated this revision to Diff 554385. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Address style comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 Files: clang/lib/Interpreter/IncrementalEx

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev updated this revision to Diff 554378. v.g.vassilev added a comment. Address review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 Files: clang/lib/Interpreter/IncrementalExecutor.cpp clang/unittests/Interpreter/Inter

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. Otherwise LGTM! Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:96-100 + JITDylibSearchOrder O; + JITDylibLookupFlags Flags = JITDylibLookupFlags::MatchExportedSy

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev created this revision. v.g.vassilev added reviewers: lhames, sunho. Herald added a project: All. v.g.vassilev requested review of this revision. ORC splits into separate dylibs symbols coming from the process and symbols materialized in the Jit. This patch adapts intent of the existi