tuliom added a comment.

In D159115#4641834 <https://reviews.llvm.org/D159115#4641834>, @mgorny wrote:

> Is that actually a regression, or merely the test wasn't checking it before?

I can't tell because the test didn't exist before.

> My educated guess would be that the code in the test redefines `printf` 
> without the header mangling, so it finds and compares the "non-IEEE" symbol 
> against the "IEEE" symbol that's exposed to the test case via the headers.

I agree with you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159115/new/

https://reviews.llvm.org/D159115

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D... Michał Górny via Phabricator via cfe-commits
  • [PATCH] D... Vassil Vassilev via Phabricator via cfe-commits
  • [PATCH] D... Sam James via Phabricator via cfe-commits
  • [PATCH] D... Michał Górny via Phabricator via cfe-commits
  • [PATCH] D... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
  • [PATCH] D... Michał Górny via Phabricator via cfe-commits
  • [PATCH] D... Michał Górny via Phabricator via cfe-commits
  • [PATCH] D... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
  • [PATCH] D... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
  • [PATCH] D... Michał Górny via Phabricator via cfe-commits
  • [PATCH] D... Tulio Magno Quites Machado Filho via Phabricator via cfe-commits
  • [PATCH] D... Vassil Vassilev via Phabricator via cfe-commits

Reply via email to