[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

2023-08-23 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3515409012fa: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

2023-08-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. @brad :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158461/new/ https://reviews.llvm.org/D158461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

2023-08-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 552204. MaskRay added a comment. update gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158461/new/ https://reviews.llvm.org/D158461 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTargets.h

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

2023-08-21 Thread Brad Smith via Phabricator via cfe-commits
brad added inline comments. Comment at: llvm/utils/gn/secondary/clang/lib/Driver/BUILD.gn:69 "ToolChains/CommonArgs.cpp", "ToolChains/Contiki.cpp", "ToolChains/CrossWindows.cpp", Here too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp and Contiki.cpp

2023-08-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 552171. MaskRay retitled this revision from "[Driver] Remove unlikely-working Minix.cpp" to "[Driver] Remove unlikely-working Minix.cpp and Contiki.cpp". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a project: LLVM. Herald

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

2023-08-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D158461#4605084 , @brad wrote: > Isn't there more than this to do a full proper removal? > > Looking around it looks like the Ananas and Contiki support can be removed. > Ananas used > to use Clang but switched back to GCC and

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

2023-08-21 Thread Brad Smith via Phabricator via cfe-commits
brad added a comment. Isn't there more than this to do a full proper removal? Looking around it looks like the Ananas and Contiki support can be removed. Ananas used to use Clang but switched back to GCC and the bits there are not maintained. The Contiki support never went anywhere. Repositor

[PATCH] D158461: [Driver] Remove unlikely-working Minix.cpp

2023-08-21 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added a reviewer: brad. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This ToolChain was added back in 2010 but has been unmaintained with no test. The constructe