[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay resigned from this revision. MaskRay added a comment. This revision now requires review to proceed. Sorry, after reading through D157750 , I think the patch should be reverted. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551680. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551634. shenhan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:1 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target MaskRay wrote: > Any reason `system-linux` is needed? Deleted. Also deleted "REQUIRES: system-linux" from "f

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551632. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551630. shenhan marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:1 +// REQUIRES: system-linux +// REQUIRES: x86-registered-target Any reason `system-linux` is needed? Comment at: clang/test/CodeGen/fsplit-machine-functio

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan marked an inline comment as done. shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s ---

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-18 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551583. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Driver/fsplit-machine-functions-with-cuda-nv

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s shenhan wrote: > MaskRay wrote:

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s MaskRay wrote: > `-target ` has

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan updated this revision to Diff 551332. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158231/new/ https://reviews.llvm.org/D158231 Files: clang/test/CodeGen/fsplit-machine-functions.c clang/test/Dr

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/CodeGen/fsplit-machine-functions.c:41 + +// RUN: %clang -c -target arm-unknown-linux-gnueabi -fsplit-machine-functions %s \ +// RUN: 2>&1 | FileCheck -check-prefix=MFS5 %s `-target ` has been deprecated s

[PATCH] D158231: [clang][test] Fix clang machine-function-split tests

2023-08-17 Thread Han Shen via Phabricator via cfe-commits
shenhan created this revision. shenhan added reviewers: MaskRay, Hahnfeld, steelannelida. Herald added subscribers: mattd, asavonic. Herald added a project: All. shenhan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This