[PATCH] D158071: [clang] Remove rdar links; NFC

cor3ntin closed this revision. cor3ntin added a comment. This was landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.org/D158071 ___ cfe-commits mailing list cfe-commit

[PATCH] D158071: [clang] Remove rdar links; NFC

MaskRay added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.org/D158071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4621631 , @zaks.anna wrote: > Looks like @NoQ wetted the remaining code changes. The rest LGTM. > > Thank you for preparing the patch! Thank you for the help with review (to both you and @NoQ)! I've landed the c

[PATCH] D158071: [clang] Remove rdar links; NFC

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks like @NoQ wetted the remaining code changes. The rest LGTM. Thank you for preparing the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4610454 , @JDevlieghere wrote: > I had a cursory look and the handful of radar links I opened and read through > didn't have any context that wasn't already in the tests. Thank you for the quick look! FWIW, I'm

[PATCH] D158071: [clang] Remove rdar links; NFC

JDevlieghere added a comment. I had a cursory look and the handful of radar links I opened and read through didn't have any context that wasn't already in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.or

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4593060 , @NoQ wrote: > Uh-oh looks like I missed 3 links that were spelled as `radar://`. I confirm > that they can be safely removed as I looked into those internal bug reports > and found no useful informatio

[PATCH] D158071: [clang] Remove rdar links; NFC

NoQ added a comment. Uh-oh looks like I missed 3 links that were spelled as `radar://`. I confirm that they can be safely removed as I looked into those internal bug reports and found no useful information to add. I'll take a brief look at the links in static analyzer tests later today or tomo

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. Having worked with phabricator for a long time, this is the first time I've seen it "pull a github" where it just doesn't want to show you the content of anything in the review. Ugh, sorry for that! You can click on Changeset List above to see the list of changed

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman created this revision. aaron.ballman added reviewers: JDevlieghere, zaks.anna, rjmccall, ahatanak. Herald added subscribers: steakhal, jdoerfert, martong, pengfei, arphaman. Herald added a reviewer: NoQ. Herald added a project: All. aaron.ballman requested review of this revision. Her