aaron.ballman added a comment.

In D158071#4610454 <https://reviews.llvm.org/D158071#4610454>, @JDevlieghere 
wrote:

> I had a cursory look and the handful of radar links I opened and read through 
> didn't have any context that wasn't already in the tests.

Thank you for the quick look! FWIW, I'm happy to leave this review open for 
longer if you'd like to take a deeper dive through the changes. Alternatively, 
I'm happy to land the changes and we can add additional comments via 
post-commit review.

Nothing is on fire where we need to land this ASAP, I just want to avoid a 
review that goes stale and is painful to keep rebased given its size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158071/new/

https://reviews.llvm.org/D158071

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to