[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-30 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked an inline comment as done. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true; MaskRay wrote: > kaz7 wrote: > > MaskRay wro

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-30 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 554742. kaz7 added a comment. By using hasFlag, change to enable VPU flag for VE by default again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813 Files: clang/include

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true; kaz7 wrote: > MaskRay wrote: > > Delete the comm

[PATCH] D157813: [Driver][VE] Support VPU flag as a feature for VE

2023-08-29 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 marked 2 inline comments as done. kaz7 added a comment. In D157813#4621978 , @MaskRay wrote: >> [VE][Clang] Change to enable VPU flag by default > > For components like llvm/, clang/, we usually use a more specific tag. I'd > pick `[Driver]` over `[