MaskRay accepted this revision.
MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22
+ std::vector<StringRef> &Features) {
+ // Defaults.
+ bool EnableVPU = true;
----------------
kaz7 wrote:
> MaskRay wrote:
> > Delete the comment. The code speaks itself.
> >
> > ```
> > if (Args.hasArg(options::OPT_mvevpu, options::OPT_mno_vevpu, true)
> > Features.push_back("+vpu");
> > ```
> Thanks. I remove comments and simplify existing code.
Sorry for my typo. We should use the 3-argument `hasFlag` here. It's simpler
than getLastArg+matches
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
