[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc861d32d7c27: [CodeGen] Keep track of eagerly emitted globals (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. I reverted the change yesterday because the test wasn't passing on Windows, for example https://lab.llvm.org/buildbot/#/builders/216/builds/25769/steps/7/logs/FAIL__Clang__inline-virtual_cpp. The problem is that the JIT cannot find `??_7type_info@@6B@` related to RTTI.

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld updated this revision to Diff 551401. Hahnfeld added a comment. Disable RTTI to (hopefully) avoid problems on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/Interpret

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8dadefd4afc: [CodeGen] Keep track of eagerly emitted globals (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

rjmccall added a comment. If we're avoiding the expense here when we're not emitting incremental extensions, this seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 ___

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev added a comment. In D156537#4587874 , @aaron.ballman wrote: > In D156537#4587832 , @v.g.vassilev > wrote: > >> @Hahnfeld, let's move forward and rely on a post-commit review here if >> necessary. >

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

aaron.ballman added a comment. In D156537#4587832 , @v.g.vassilev wrote: > @Hahnfeld, let's move forward and rely on a post-commit review here if > necessary. Because one of the codegen code owners has been active on the thread with concerns, I think

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. @Hahnfeld, let's move forward and rely on a post-commit review here if necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1565

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. In D156537#4554413 , @v.g.vassilev wrote: > In D156537#4554052 , @Hahnfeld > wrote: > >> @v.g.vassilev do we have a means to detect this case? In D156897 >>

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev added a comment. In D156537#4554052 , @Hahnfeld wrote: > @v.g.vassilev do we have a means to detect this case? In D156897 > , I'm refactoring all accesses to > `EmittedDeferredDecl` to go via `addEmittedDef

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. @v.g.vassilev do we have a means to detect this case? In D156897 , I'm refactoring all accesses to `EmittedDeferredDecl` to go via `addEmittedDeferredDecl`, so we should just add an early return when not emitting for a REPL. Reposito

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

rjmccall added a comment. I would like to avoid the overhead of this when we're not emitting for a REPL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 ___ cfe

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, rjmccall, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An inline virtual function must be emitted, but we need t