v.g.vassilev added a comment. In D156537#4587874 <https://reviews.llvm.org/D156537#4587874>, @aaron.ballman wrote:
> In D156537#4587832 <https://reviews.llvm.org/D156537#4587832>, @v.g.vassilev > wrote: > >> @Hahnfeld, let's move forward and rely on a post-commit review here if >> necessary. > > Because one of the codegen code owners has been active on the thread with > concerns, I think it's better to wait a bit longer for an explicit sign-off > that those concerns are addressed (this code impacts more than clang-repl). D157379 <https://reviews.llvm.org/D157379> seems to resolve the concern but indeed we can wait a little longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
