This revision was automatically updated to reflect the committed changes.
Closed by commit rL255770: [clang-tidy] Add namespace support to
add_new_check.py (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D15571?vs=43007&id=43008#toc
Repository:
rL LLVM
http://reviews.
congliu marked 2 inline comments as done.
congliu added a comment.
Replace namespace with module -- Done.
Remove extra space after module -- Done.
http://reviews.llvm.org/D15571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
I'll commit the patch for you.
http://reviews.llvm.org/D15571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
congliu updated this revision to Diff 43007.
congliu added a comment.
Replaced namespace with module;
Removed extra space after module at line 103
http://reviews.llvm.org/D15571
Files:
clang-tidy/add_new_check.py
Index: clang-tidy/add_new_check.py
alexfh added inline comments.
Comment at: clang-tidy/add_new_check.py:99
@@ -97,1 +98,3 @@
+ 'check_name_dashes': check_name_dashes,
+ 'namespace': module})
Thinking about this once again, let's replace `namespace` with `module` for
consistency.
==
congliu created this revision.
congliu added a reviewer: alexfh.
congliu added a subscriber: cfe-commits.
Without namespace you can not create checks with same name in different modules
http://reviews.llvm.org/D15571
Files:
clang-tidy/add_new_check.py
Index: clang-tidy/add_new_check.py
==
